Fix scrolling and overflow in route viewer. #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
approved these changes
Feb 2, 2021
landonreed
requested changes
Feb 4, 2021
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
This is on the right track, but we need to add css to some inner div (not sure which) to get an ellipsis on overflow. Also, the title prop should be populated with the route name value.
landonreed
approved these changes
Feb 12, 2021
Member
|
@binh-dam-ibigroup, I'm going to go ahead and merge. I don't think the changes since @evansiroky's review really warrant another look from him. |
Merged
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #320.
EDIT: Per request at #321 (review), long clipped route labels in the route viewer are rendered with an ellipsis (this changes the rendering code for the route viewer to take advantage of flex boxes).