Skip to content

Redirect to hash URL if search URL contains no hash #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

Redirect to hash URL if search URL contains no hash #327

merged 2 commits into from
Feb 22, 2021

Conversation

@landonreed
Copy link
Member

@landonreed landonreed commented Feb 9, 2021

Fixes #325. To test:

  1. Use trimet call config
  2. Go to http://localhost:9966?sessionId=test
  3. Auto-redirects to http://localhost:9966/#/?sessionId=test
  4. Trips are now plannable (previously things errored out in the app).

@landonreed landonreed mentioned this pull request Feb 9, 2021
Closed
@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Feb 9, 2021
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Feb 20, 2021
@landonreed landonreed merged commit 1febf2b into dev Feb 22, 2021
@landonreed landonreed deleted the fix-url-hash branch February 22, 2021 14:52
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Feb 23, 2021
Closed
@evansiroky evansiroky mentioned this pull request Mar 31, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2021

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web app cannot handle query params if hash (#) is missing

4 participants

@landonreed @evansiroky @binh-dam-ibigroup