Skip to content

Conversation

@landonreed
Copy link
Member

This PR adds a delete my account button the user account settings page.

After deletion, the user is logged out (and redirected to the application root URL).

image

@codecov-io
Copy link

Codecov Report

Merging #335 (39fd5bc) into dev (0457a25) will decrease coverage by 0.68%.
The diff coverage is 9.88%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev    #335      +/-   ##
========================================
- Coverage   9.78%   9.10%   -0.69%     
========================================
  Files        115     176      +61     
  Lines       4078    6483    +2405     
  Branches    1077    1684     +607     
========================================
+ Hits         399     590     +191     
- Misses      3191    5052    +1861     
- Partials     488     841     +353     
Impacted Files Coverage Δ
lib/actions/auth.js 0.00% <0.00%> (ø)
lib/actions/call-taker.js 0.00% <0.00%> (ø)
lib/actions/form.js 22.22% <0.00%> (-0.36%) ⬇️
lib/actions/ui.js 19.83% <0.00%> (-0.17%) ⬇️
lib/actions/user.js 0.00% <0.00%> (ø)
lib/components/admin/call-record.js 0.00% <0.00%> (ø)
lib/components/admin/call-taker-controls.js 0.00% <0.00%> (ø)
lib/components/admin/call-taker-windows.js 0.00% <0.00%> (ø)
lib/components/admin/call-time-counter.js 0.00% <0.00%> (ø)
lib/components/admin/draggable-window.js 0.00% <0.00%> (ø)
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f3502...39fd5bc. Read the comment docs.

@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Feb 24, 2021
Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one suggestion that I feel somewhat opinionated about to make sure that the components don't get cluttered with logic that can just be in actions.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Feb 25, 2021
@landonreed landonreed merged commit 5494729 into dev Feb 25, 2021
@landonreed landonreed deleted the delete-user branch February 25, 2021 14:55
@evansiroky evansiroky mentioned this pull request Mar 31, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants