Terms of service #340
Terms of service #340
Conversation
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good! But I think there's some extra abstraction in here that may not be needed.
lib/components/app/app-frame.js
Outdated
| <AppFrame> | ||
| {Component | ||
| ? <Component /> | ||
| : <p>No content provided.</p> |
There was a problem hiding this comment.
Maybe we should create a PageNotFound component and render that if Component does not exist (it could have a link back to the main trip planner).
There was a problem hiding this comment.
Hmm I have set these pages to open in new tabs, so does a link make sense with this setup?
There was a problem hiding this comment.
Yea, perhaps no link in that case.
There was a problem hiding this comment.
I enhanced the format for not found content in f956388.
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
OK yep, thanks for clarifying that need for AppFrame. Only one non-blocking comment about creating/using a PageNotFound page that gives a little more help to the user to get back to the main trip planner.
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
Good to go pending merge conflict resolution
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR defines two new
optional,custom component entries in thecomponentscontext that are required for OTP middleware implementations:TermsOfService(accessed from the "terms of service..." checkbox in the user account page)TermsOfStorage(accessed from the "terms of storage" checkbox in the user account page)The PR implements the routes and wrappers to display these components.
(The contents of these components is out of scope.)