Bump core-utils for default query override #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### The default query parameters can be overridden be uncommenting this object. | ||
| ### Note: the override values must be valid values within otp-ui's query-params.js | ||
| # defaultQueryParams: | ||
| # maxWalkDistance: 3219 # 2 miles in meters |
Collaborator
There was a problem hiding this comment.
The UI does not seem to be set on the default query params, does this PR intend to do that?
As an example, if you set optimize: TRANSFERS, the optimization setting will still appear as SPEED in the UI (with a red dot indicating that that is not the default setting, though.)
binh-dam-ibigroup
approved these changes
Apr 9, 2021
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Just a suggestion to reword the comment regarding defaultQueryParams but I'm inclined to accept as is.
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test config override, add this bit from
example-config.ymlto your active config:otp-react-redux/example-config.yml
Lines 18 to 21 in 860d6dc