fix(switch-button): automatically re-plan after clicking #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
Nov 17, 2021
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
Contributor
|
All you needed to do was make this return a promise? Does that mean this was originally the intended functionality but wasn't working properly? |
daniel-heppner-ibigroup
approved these changes
Nov 22, 2021
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
Collaborator
Author
|
I think some change must have happened somewhere that allowed the race condition to occur? But yes I do believe that this was the intended functionality. |
Contributor
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
miles-grant-ibigroup
added a commit
that referenced
this pull request
Mar 14, 2022
Correctly Merge #503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch button was doing everything correctly, but because didn't wait for dispatches to finish, had an internal race condition that sometimes resulted in it not planning the new trip.
This PR fixes this.