Add tsc to yarn test and fix typescript
#534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Jan 28, 2022
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
philip-cline
approved these changes
Mar 18, 2022
| paneSequence, | ||
| title | ||
| }: { | ||
| onCancel: () => void |
Contributor
There was a problem hiding this comment.
In the tech call a few weeks ago, I think we decided to consistently include explicit types for the props of React components. This is what we meant by that right (defining after props in a list, rather than exporting to a type like StackedPaneDisplayProps?) Not raising an issue here just using this as a use case to make sure I understand.
Collaborator
Author
There was a problem hiding this comment.
Yep! 2f41852 is how this would look following our new agreed-upon pattern
Contributor
There was a problem hiding this comment.
Gucci. Thanks for the explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
tscto our tests and then fixes bugs found via runningyarn tsc.Also cut the ci time in almost half since we're now only running the accessibility tests once!