Update issue reporting template #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
binh-dam-ibigroup
approved these changes
Feb 4, 2022
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Conditional approval upon merging #542.
…emplate-qbd Update issue reporting template qbd
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Feb 8, 2022
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Some code structure thoughts... but still approving since my opinion might not be the best here!
| ) | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This feels like it would work well as a functional component.
| const { buttonTypes, reactRouterConfig, reportConfig } = this.props | ||
|
|
||
| const buttonComponents = [] | ||
| buttonTypes.forEach((type) => { |
Contributor
There was a problem hiding this comment.
How about a map to map buttonTypes to buttonComponents?
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
Collaborator
Author
|
You're definitely right on both fronts and I think we should do both of these fixes when we move this file to Typescript, hopefully soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous issue reporting email template left a lot to be desired in terms of user experience. This PR attempts to make the template more user friendly.
French translations are now obsolete and need to be updated @binh-dam-ibigroup