Handle any route w webapp + support otp.js legacy start route #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #81 +/- ##
========================================
- Coverage 5.19% 5.19% -0.01%
========================================
Files 135 135
Lines 5905 5911 +6
Branches 1730 1734 +4
========================================
Hits 307 307
- Misses 4735 4738 +3
- Partials 863 866 +3
Continue to review full report at Codecov.
|
evansiroky
reviewed
Jul 18, 2019
lib/actions/ui.js
Outdated
| // pathname to specify lat, lon, etc.) | ||
| [,, lat, lon, zoom, routerId] = idToParams(location.pathname, '/') | ||
| } | ||
| console.log('Setting start position/zoom/router', lat, lon, zoom, routerId) |
evansiroky
approved these changes
Jul 18, 2019
Merged
Contributor
|
🎉 This PR is included in version 0.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously visiting any random route (e.g., https://trimet-mod-dev.ibi-transit.com/#/foo) causes a blank page to be rendered. This fixes that.
It also adds support for the legacy
startroute used in otp.js to specify lat/lon/zoom/router.