Skip to content

BUILD: fix cuda configure#1252

Merged
Sergei-Lebedev merged 1 commit intoopenucx:masterfrom
ikryukov:fix-configure-m4-syntax
Jan 7, 2026
Merged

BUILD: fix cuda configure#1252
Sergei-Lebedev merged 1 commit intoopenucx:masterfrom
ikryukov:fix-configure-m4-syntax

Conversation

@ikryukov
Copy link
Collaborator

@ikryukov ikryukov commented Jan 7, 2026

What

fixed m4 config syntaxis

Why ?

followup after latest commit

Signed-off-by: Ilya Kryukov <ikryukov@nvidia.com>
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 7, 2026

Greptile Summary

Fixed broken AS_IF macro syntax in CUDA configure script by properly nesting the conditional statements and adding proper variable quoting ("x$variable" instead of bare $variable).

  • Corrected nested AS_IF structure for checking nvml_happy condition
  • Added "x" prefix to variable comparisons following m4 best practices and codebase conventions
  • Ensures proper error message display when TL CUDA is disabled

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes fix a clear syntax error in m4 macro configuration. The fix follows established patterns in the codebase (proper variable quoting and nested AS_IF structure), and only affects build-time configuration logic with no runtime impact.
  • No files require special attention

Important Files Changed

Filename Overview
src/components/tl/cuda/configure.m4 Fixed nested AS_IF syntax and added proper variable quoting in test conditions

@Sergei-Lebedev
Copy link
Contributor

/build

@Sergei-Lebedev Sergei-Lebedev merged commit 558c060 into openucx:master Jan 7, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants