Closed
Conversation
main header, status, typedefs, version
ucc_lib_init/cleanup
Constructor: detect plugin path, dlopen all available
plugins (tls)
Lib_init: create lib object and fill with plugins based on filtering
mike-dubman
reviewed
Sep 28, 2020
| component_install = ucc_team_lib_basic.la | ||
|
|
||
| ucc_team_lib_basic_la_SOURCES =$(sources) | ||
| ucc_team_lib_basic_la_CPPFLAGS = $(AM_CPPFLAGS) $(VMC_CPPFLAGS) |
mike-dubman
reviewed
Sep 28, 2020
| component_install = ucc_team_lib_debug.la | ||
|
|
||
| ucc_team_lib_debug_la_SOURCES =$(sources) | ||
| ucc_team_lib_debug_la_CPPFLAGS = $(AM_CPPFLAGS) $(VMC_CPPFLAGS) |
Contributor
There was a problem hiding this comment.
also here and next line
shimmybalsam
pushed a commit
to shimmybalsam/ucc
that referenced
this pull request
May 1, 2022
TEST: add ci for ucc
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Feb 2, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4. Co-authored-by: Cursor <cursoragent@cursor.com>
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Mar 5, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4. Co-authored-by: Cursor <cursoragent@cursor.com>
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Mar 25, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Mar 25, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
janjust
pushed a commit
to QiaoK/ucc
that referenced
this pull request
Apr 1, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Apr 6, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Apr 6, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
janjust
pushed a commit
to QiaoK/ucc
that referenced
this pull request
Apr 7, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
QiaoK
added a commit
to QiaoK/ucc
that referenced
this pull request
Apr 7, 2026
Move all datatype validation logic from ucc_coll.c to ucc_service_coll.c to avoid increasing ucc_coll_task_t size. Key changes: 1. Remove dt_check field from ucc_coll_task_t - Saves 8 bytes per task (pointer eliminated) - dt_check only exists when validation is needed 2. Create ucc_dt_check_schedule_t extending ucc_schedule_t - Embeds ucc_dt_check_state_t directly in schedule - Only allocated when validation is required - No overhead for tasks without validation 3. Add ucc_service_dt_check() API in ucc_service_coll.h - Single entry point for datatype validation - Creates validation schedule if needed - Returns original task if validation not needed - Encapsulates all validation complexity 4. Move all validation functions to ucc_service_coll.c (~480 lines) - ucc_dt_check_allreduce_post/progress/finalize - ucc_dt_check_actual_wrapper_post/progress/finalize - ucc_dt_check_schedule_finalize - ucc_service_dt_check (main entry point) - Helper macros to access dt_check from schedule 5. Update ucc_coll.c to use new API - Replace ucc_dt_check_start_validation + ucc_dt_check_create_schedule - Single call to ucc_service_dt_check() - Remove ~500 lines of validation code Benefits: - Reduced memory footprint: no dt_check pointer in every task - Better code organization: validation logic in service_coll module - Cleaner API: single function instead of two-step process - No performance impact: same validation mechanism Addresses PR review comment openucx#4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds minimal functional example implementation of the UCC component architecture. (currently the API prefix is "TL" which stands for "Team Library").
pwd/install --with-ucx=$UCX_DIR; make -j installrun tests: