UCS/SYS: Delete redundant code in ucs_read_file_vararg #10691
Conversation
|
I find this because of Coverity check fail on my initial PR: #10690 |
|
@dschervov, thx for the patch, do you have signed CLA? |
Yes! Send it (18th May) from: dschervov1@yandex.ru, to: admin@ucfconsortium.org |
|
@iyastreb I am grateful for the review and your approve! Probably, we need to restart "UCX PR (Tests BlueField on worker 1) since it is unreachable: |
Can you please resolve conflict? |
Yes of cource! Grateful for your help! My bad : - ( Did not see the conflict... |
|
It again stuck... Stop hearing from workers... And some error that there are no memory to allocate... |
|
@dschervov maybe you can rebase and force-push, then it would trigger CI restart |
Yes, great idea!!! I do just like that if i encounter this problem again! Thank you for your help! |
|
i meant, can you pls squash commits to have a single commit with just your change? |
|
I apologize! This mistake will not happen again! I create new clean PR: #10713 |
3 participants
What?
Delete redundant code in "ucs_read_file_vararg" function.
Why?
There is no point to check if "read_bytes" is less than "max" because we are calling "read" with buffer size "max - 1".
How?
Thereforce we can delete redundant check and always terminate the buffer (string) in "read_bytes" position.