Open
Conversation
tvegas1
reviewed
Feb 3, 2026
| # Remove superfluous dependency | ||
| dpkg-deb -R "ucx-cuda-${VER}.deb" tmp # Extract | ||
| sed -i 's/libnvidia-compute | libnvidia-ml1, //g' tmp/DEBIAN/control | ||
| sed -i 's/libnvidia-compute | libnvidia-ml1.*, //g' tmp/DEBIAN/control |
Contributor
There was a problem hiding this comment.
Seems it does greedy match, other package is eaten, see below:
$ echo 'Depends: libc6 (>= 2.34), libnvidia-compute | libnvidia-ml1 (>= 555.42.06), other, ucx' | \
sed 's/libnvidia-compute | libnvidia-ml1.*, //g'
Depends: libc6 (>= 2.34), ucx
Maybe something like:
$ echo 'Depends: libc6 (>= 2.34), libnvidia-compute | libnvidia-ml1 (>= 555.42.06), other, ucx' | sed 's/libnvidia-compute | libnvidia-ml1[^,]*, //'
Depends: libc6 (>= 2.34), other, ucx
Contributor
|
To unblock CI, please rename PR/commit with something like "AZP: Fix debian package dependency cleanup", and provide actual email address in AUTHORS file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove
libnvidia-computedependency from debian package dependencies.Why?
Fixes #11140
How?
It appears the string
sed -i 's/libnvidia-compute | libnvidia-ml1, //g' tmp/DEBIAN/controlis replacing has changed:Updating the pattern with a wildcard match seems to work: