portion of UCP related fixes for PGI#4260
Merged
brminich merged 1 commit intoopenucx:masterfrom Oct 11, 2019
Merged
Conversation
Contributor
hoopoepg
commented
Oct 8, 2019
hoopoepg
commented
- first portion of UCP related fixes for PGI compiler support
|
Test PASSed. |
Contributor
|
Test PASSed. |
Contributor
brminich
requested changes
Oct 9, 2019
| p += sizeof(ucp_md_map_t); | ||
|
|
||
| *((uint8_t *)p++) = mem_type; | ||
| *(p++) = mem_type; |
Contributor
There was a problem hiding this comment.
plz remove casting on line 59 as well
| ucs_for_each_bit(md_index, md_map) { | ||
| md_size = *((uint8_t*)rkey_buffer); | ||
| rkey_buffer += sizeof(uint8_t); | ||
| md_size = *((uint8_t*)rkey_buf); |
| } | ||
| }; | ||
|
|
||
| static ucs_stats_class_t ucp_worker_stats_class = { |
Contributor
Author
There was a problem hiding this comment.
PGI compiler bug, reported to PGI compiler team
brminich
approved these changes
Oct 9, 2019
|
Test PASSed. |
dmitrygx
approved these changes
Oct 9, 2019
Contributor
Author
|
bot:mlx:retest |
Contributor
|
Test PASSed. |
Contributor
Mellanox CI: PASSED on 29 workers (click for details)Note: the logs will be deleted after 17-Oct-2019
|
Contributor
|
plz, resolve conflict |
- first portion of UCP related fixes for PGI compiler support
hoopoepg
force-pushed
the
topic/portion-ucp-fixes-for-pgi
branch
from
86e1a97 to
a3cb967
Compare
Contributor
|
Test PASSed. |
Contributor
Mellanox CI: PASSED on 29 workers (click for details)Note: the logs will be deleted after 17-Oct-2019
|
|
Test FAILed. |
Contributor
|
Test FAILed. |
Contributor
Mellanox CI: FAILED on 8 of 29 workers (click for details)Note: the logs will be deleted after 17-Oct-2019
|
Contributor
Author
|
bot:mlx:retest |
Contributor
|
Test PASSed. |
Contributor
Mellanox CI: PASSED on 29 workers (click for details)Note: the logs will be deleted after 18-Oct-2019
|
Contributor
Author
|
bot:bgate:retest |
|
Test PASSed. |
Contributor
Author
|
@brminich ok to merge? |
brminich
approved these changes
Oct 11, 2019
Contributor
|
we need to add PGI checks to our CI asap. Looks like it is very easy to break PGI compilation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.