Update sync split-button example with changes in Explainer doc#125
Merged
gregwhitworth merged 6 commits intoopenui:componentsfrom Jul 14, 2020
Merged
Update sync split-button example with changes in Explainer doc#125gregwhitworth merged 6 commits intoopenui:componentsfrom
gregwhitworth merged 6 commits intoopenui:componentsfrom
Conversation
…x typo in CSS class
…art. With this change, the split-button no longer needs to preventDefault to make only the arrow section of the button open the listbox.
…ighted instead of watching for checked. This way there's a visual indicator when using up/down arrows to select a value.
…istbox part. Refactor so that the same functions are used to apply controller code to both the default parts and the user-supplied parts, to ensure that these remain consistent.
gregwhitworth
requested changes
Jul 13, 2020
Member
gregwhitworth
left a comment
There was a problem hiding this comment.
I love the changes to the controller code. You'll need to put the part='button' back onto the button-container or come up with another solution for it to match the bootstrap example (I linked to it in the code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update select implementation so that the controller code is applied to the button and listbox parts directly, rather than using the
<slot>s.Refactor so that the same code adds controller functionality to both the default parts and to the user-replaced parts, which should make it easier to keep these in-sync.
In the split-button example: