Conversation
iskandr
force-pushed
the
variant_collection_filtering
branch
from
0f451c7 to
4a49b26
Compare
… drop_duplicates to be a method on Variant Collection
Contributor
Author
There was a problem hiding this comment.
Added an assert that the expected length matches the given one in the MAF file.
Contributor
|
What |
Contributor
There was a problem hiding this comment.
No __hash__ for Variant?
Contributor
Author
There was a problem hiding this comment.
Oh, I thought there already was one! I guess I forgot to add it when I adding __hash__ and __eq__ to all the PyEnsembl objects.
Contributor
|
Looks good to me aside from comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VariantCollectionobjects (useload_variantsfunction instead)clonemethod toVariantCollectionto simplify adding other filter methodsdrop_duplicatesfrom a file loading argument to be a method onVariantCollectiondrop_duplicates