Improve compile times by removing unnecessary headers#12
Merged
matthewdcong merged 3 commits intomainfrom Sep 16, 2025
Merged
Conversation
Signed-off-by: Matthew Cong <mcong@nvidia.com>
Signed-off-by: Matthew Cong <mcong@nvidia.com>
41d19e1 to
98959f3
Compare
fwilliams
approved these changes
Sep 16, 2025
Signed-off-by: Matthew Cong <mcong@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves around 5s per translation unit in my builds, which equates to about 40s of end-to-end parallel build time on my machine. On CI, this brings build times with CUDA 12.8 from 9m 20s to 7m and 50s and on CUDA 12.9 from 14m 45s to 8m 38s.
Tensoranddtypesand including torch/types.h instead of the much larger torch/all.h is sufficient.