Fix/improve radix sort synchronization#409
Merged
Merged
Conversation
Signed-off-by: Matthew Cong <mcong@nvidia.com>
matthewdcong
force-pushed
the
improve_radix_sort_sync
branch
from
efd7723 to
6d64f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The item offsets and counts arrays are only accessed on the host. Prior to this PR, these were allocated in Unified Memory without the appropriate synchronization. This leads to a rare race condition and also necessitates additional host-device synchronization at the beginning of the radix sort loop. Migrating these arrays to the host fixes the race condition and removes the need to synchronize.