Pin CI checkout refs to immutable commit SHAs to fix build/test skew#503
Merged
Conversation
When the build and test jobs checked out the base branch by name (e.g. "main"), a PR merged between the build and test phases could advance the branch tip, causing test jobs to run newer tests against an older built package. Fix by using github.event.pull_request.base.sha and github.sha instead of branch refs, and fetching the PR head by its exact SHA rather than the mutable pull/N/head ref. All values are constants within a single workflow run, guaranteeing every job sees the same source tree. Applied to tests.yml, cu128.yml, and cu130.yml. Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
swahtz
added
CI
matthewdcong
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build and test jobs checked out the base branch by name (e.g. "main"), a PR merged between the build and test phases could advance the branch tip, causing test jobs to run newer tests against an older built package. Fix by using
github.event.pull_request.base.shaandgithub.shainstead of branch refs, and fetching the PR head by its exact SHA rather than the mutable pull/N/head ref. All values are constants within a single workflow run, guaranteeing every job sees the same source tree.Applied to tests.yml, cu128.yml, and cu130.yml.