Skip to content

Conversation

@daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Feb 28, 2025

Reopen of the #2862

Changes

  • Embedding nodes are used as input nodes for the inference graph (with that embedding nodes are being included to the inference_nncf_graph)
    *both nncf_graph and inference_nncf_graph is used to identify weighted nodes
  • PT/FX MinMax get_weight_nodes method is updated to work with the graph / inference graph pair
  • Constant folding is removed from the OpenVINOQuantizer and FX nncf.quantize implementation
  • New symbolic types are introduced for the TorchFX NNCFGraphBuilder

Reason for changes

Related tickets

163025
#3371

Tests

  • tests/cross_fw/test_templates/test_quantizer_config.py is updated with shape_of /constant embedding model and conv model with constant branches
  • TorchFX reference graphs for VIT and Swin were updated: constant branches are present in the quantized graph but they don't have quantizers inside
  • conformance test post_training_quantization/625/ - passed
  • References are updated for models with a constant branches

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ experimental labels Feb 28, 2025
@daniil-lyakhov daniil-lyakhov force-pushed the dl/shape_of_sub_emb_fix branch from 9689dca to 0a2f240 Compare February 28, 2025 11:36
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review February 28, 2025 13:28
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner February 28, 2025 13:28
@github-actions github-actions bot added the API Public API-impacting changes label Mar 17, 2025
@daniil-lyakhov daniil-lyakhov force-pushed the dl/shape_of_sub_emb_fix branch 2 times, most recently from 6d87191 to f3d020a Compare March 20, 2025 15:10
@github-actions github-actions bot removed the API Public API-impacting changes label Mar 20, 2025
@daniil-lyakhov daniil-lyakhov force-pushed the dl/shape_of_sub_emb_fix branch from 8d676a8 to 3a566ba Compare March 21, 2025 16:09
@AlexanderDokuchaev AlexanderDokuchaev merged commit dc8eb03 into openvinotoolkit:develop Mar 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants