[GHA] Add missing jobs to workflow overal status #2893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where failures in certain CI jobs (specifically NodeJS tests) did not cause the overall workflow status to fail. The fix adds missing job dependencies to the Overall_Status job's needs list across multiple workflow files.
Key changes:
- Added
genai_build_nodejsandgenai_nodejs_testsjobs to workflows where they were missing from the overall status check - Added
store_artifactsjob to the dependencies in multiple workflows - Added
genai_xgrammar_off_teststo the Linux workflow's overall status
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/windows.yml | Added store_artifacts, genai_build_nodejs, and genai_nodejs_tests to Overall_Status dependencies |
| .github/workflows/manylinux_2_28.yml | Added store_artifacts and genai_build_nodejs to Overall_Status dependencies |
| .github/workflows/mac.yml | Added genai_build_nodejs and genai_nodejs_tests to Overall_Status dependencies |
| .github/workflows/linux.yml | Added store_artifacts and genai_xgrammar_off_tests to Overall_Status dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Wovchena
requested changes
Oct 23, 2025
Wovchena
approved these changes
Oct 23, 2025
Merged
via the queue into
openvinotoolkit:master
with commit Oct 30, 2025
cb17ac9
122 of 124 checks passed
Wovchena
pushed a commit
to Wovchena/openvino.genai-public
that referenced
this pull request
Nov 5, 2025
## Description NodeJS test didn't fail overal workflow status: https://github.com/openvinotoolkit/openvino.genai/actions/runs/18723441840/job/53404679076?pr=2881 This PR includes all workflow jobs to overal_status.needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NodeJS test didn't fail overal workflow status: https://github.com/openvinotoolkit/openvino.genai/actions/runs/18723441840/job/53404679076?pr=2881
This PR includes all workflow jobs to overal_status.needs.