-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[Snippets] Fix register type assignment for pass through expressions #29599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
a-sidorova
merged 3 commits into
openvinotoolkit:master
from
aobolensk:live_ranges-type-assign-fix
Mar 26, 2025
Merged
[Snippets] Fix register type assignment for pass through expressions #29599
a-sidorova
merged 3 commits into
openvinotoolkit:master
from
aobolensk:live_ranges-type-assign-fix
Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7531254 to
0b19c9a
Compare
a-sidorova
reviewed
Mar 24, 2025
577a2dd to
dd6e7e2
Compare
a-sidorova
reviewed
Mar 24, 2025
a-sidorova
approved these changes
Mar 24, 2025
Contributor
a-sidorova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the fix! 👍🏼
v-Golubev
approved these changes
Mar 25, 2025
timxu826
pushed a commit
to timxu826/openvino
that referenced
this pull request
Apr 7, 2025
…penvinotoolkit#29599) ### Details: Fix skipped register type assignment for in `InitLiveRanges` pass for expressions that don't affect lifetime of registers (list is defined in `pass_through_expr` function of this pass) ### Tickets: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fix skipped register type assignment for in
InitLiveRangespass for expressions that don't affect lifetime of registers (list is defined inpass_through_exprfunction of this pass)Tickets: