[PT FE] Support aten::smooth_l1_loss#29637
Closed
johnrhimawan wants to merge 1 commit intoopenvinotoolkit:masterfrom
Closed
[PT FE] Support aten::smooth_l1_loss#29637johnrhimawan wants to merge 1 commit intoopenvinotoolkit:masterfrom
aten::smooth_l1_loss#29637johnrhimawan wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
mvafin
requested changes
Apr 1, 2025
Contributor
mvafin
left a comment
mvafin
left a comment
There was a problem hiding this comment.
Please also fix code style
| auto beta = node.get_attribute<float>("beta", 1.0); | ||
|
|
||
| // Create constants with input's element type | ||
| auto beta_const = v0::Constant::create(input.get_element_type(), Shape{}, {beta}); |
Contributor
There was a problem hiding this comment.
Suggested change
| auto beta_const = v0::Constant::create(input.get_element_type(), Shape{}, {beta}); | |
| auto beta_const = v0::Constant::create(input.get_element_type(), Shape{}, {beta}); |
Do not use get_element_type from input to create constant. Input type can be unknown - dynamic. Your tests fail because of that.
Use ConvertLike instead
Contributor
Author
There was a problem hiding this comment.
Thank you for the comments and suggestions, I'll try get working on that :)
Contributor
|
hey @ johnrhimawan any progress here? |
Contributor
Author
Hi sorry I'm still in a busy period with university, but I'll get on it after 👍 |
Contributor
|
sure, education first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
aten::smooth_l1_lossTickets: