Skip to content

Conversation

@VaishnaviOnPC
Copy link

@VaishnaviOnPC VaishnaviOnPC commented Apr 4, 2025

Support quantized::conv1d, quantized::linear_relu

@mvafin
Copy link
Contributor

mvafin commented Apr 7, 2025

Well... You at least need to add an operation in op_table.cpp in the list of supported operations.

@VaishnaviOnPC VaishnaviOnPC requested a review from mvafin April 7, 2025 16:14
@mvafin
Copy link
Contributor

mvafin commented Apr 11, 2025

Your code doesn't build

@VaishnaviOnPC
Copy link
Author

Your code doesn't build

I noticed that too and have repeatedly checked but the code seems fine. Is there any thing I can change to remove that error? I have strictly followed the code pattern for tests as well.

@VaishnaviOnPC
Copy link
Author

also the commit history is a bit polluted because of all those random commits, should i just rebase it for it to work out?

@mvafin
Copy link
Contributor

mvafin commented Apr 14, 2025

also the commit history is a bit polluted because of all those random commits, should i just rebase it for it to work out?

No need to rebase, it is fine

@mvafin
Copy link
Contributor

mvafin commented Apr 16, 2025

Please check the tests. You have mismatch in kernel size

@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 29, 2025
@VaishnaviOnPC
Copy link
Author

I still wish to work on this pr, I was busy with a few hackathons, I will work on this in the next few days, please do not close it.

@github-actions github-actions bot removed the Stale label Jul 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support quantized::conv1d, quantized::linear_relu

4 participants