-
Notifications
You must be signed in to change notification settings - Fork 3k
Pull Resquest regarding [Good First Issue]: Support quantized::conv1d, quantized::linear_relu #29343 #29948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well... You at least need to add an operation in op_table.cpp in the list of supported operations. |
|
Your code doesn't build |
I noticed that too and have repeatedly checked but the code seems fine. Is there any thing I can change to remove that error? I have strictly followed the code pattern for tests as well. |
This reverts commit ee6bfa4.
|
also the commit history is a bit polluted because of all those random commits, should i just rebase it for it to work out? |
No need to rebase, it is fine |
|
Please check the tests. You have mismatch in kernel size |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
I still wish to work on this pr, I was busy with a few hackathons, I will work on this in the next few days, please do not close it. |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Support quantized::conv1d, quantized::linear_relu