[PT FE] Support aten::reverse operation #29951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvafin
changed the title
mvafin
reviewed
Apr 7, 2025
| @@ -0,0 +1,43 @@ | |||
| #include "reverse.hpp" | |||
| #include "openvino/opsets/opset10.hpp" | |||
Contributor
There was a problem hiding this comment.
Please do not use opset header, include every operation separetly
mvafin
requested changes
Apr 7, 2025
Contributor
mvafin
left a comment
mvafin
left a comment
There was a problem hiding this comment.
You didn't add your operation in op_table.cpp. It will never be used
Contributor
There was a problem hiding this comment.
.hpp is not needed. Declare your conversion in op_table.cpp
|
|
||
| # 2. Test signature must include ie_device and precision fixtures | ||
| @pytest.mark.parametrize("dim", [0, 1, 2]) | ||
| def test_reverse_tensor(dim, ie_device, precision): |
Contributor
There was a problem hiding this comment.
Please use class PytorchLayerTest and rewrite the tests to be similar to other tests
Contributor
|
hey @MyatKaung will you find a time to adress code review requests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add PyTorch frontend support for the
aten::reverseoperator by translating it to OpenVINO’sReverseSequenceop.Why
Issue #29713 tracks adding
reversesupport in the PyTorch frontend.How
translate_reverseinsrc/frontends/pytorch/src/op/reverse.cpp/.hpp"aten::reverse"insrc/frontends/pytorch/src/op_table.cpptests/layer_tests/pytorch_tests/test_reverse.pyTicket
Fixes #29713