[PT FE] support aten::kthvalue#31397
Merged
mvafin merged 4 commits intoSep 17, 2025
Merged
Conversation
f6119b7 to
ef28baa
Compare
ef28baa to
d2fa2b3
Compare
Contributor
Author
|
@mvafin @PiotrKrzem Hi! This has been awaiting a review for a while now. Any suggestions? |
mvafin
reviewed
Sep 5, 2025
mvafin
reviewed
Sep 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the PyTorch aten::kthvalue operation by implementing translation logic that uses TopK with sorted values followed by gathering the kth index.
- Implements
translate_kthvaluefunction using TopK operation with MIN mode and value sorting - Adds comprehensive test coverage for various shapes, dimensions, and data types
- Registers the new operation in the PyTorch frontend operation table
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/layer_tests/pytorch_tests/test_kthvalue.py |
Adds comprehensive test suite for kthvalue operation with parametrized test cases |
src/frontends/pytorch/src/op_table.cpp |
Registers the translate_kthvalue function and maps aten::kthvalue operation |
src/frontends/pytorch/src/op/kthvalue.cpp |
Implements the core translation logic using TopK and Gather operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
build_jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
TopKwith sorted values, then gather thekth index.Tickets: