Skip to content

Conversation

@songbell
Copy link
Contributor

Signed-off-by: fishbell bell.song@intel.com

Details:

  • add detailed formula on RNNCell spec
  • add explanation on RNNSequence attribute direction

Tickets:

  • 48463

@songbell songbell requested a review from a team as a code owner October 19, 2021 06:18
@songbell songbell requested review from tsavina and removed request for a team October 19, 2021 06:18
@songbell songbell requested a review from rkazants October 19, 2021 06:20
@songbell
Copy link
Contributor Author

merged PR from #7295


*RNNCell* represents a single RNN cell and is part of [RNNSequence](RNNSequence_5.md) operation.

Ho = f(clip(X*(W^T) + H*(R^T) + B)) is a formula for the operation, where * is matrix multiplication, ^T is a matrix transpose operation and explanations for X, H, W, B, Ho, clip, and f are given in Attributes and Inputs sections.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsavina, could you please check formatting of formulas and denotations because it seems incorrect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatted the formula, please check again @rkazants @tsavina

Signed-off-by: fishbell <bell.song@intel.com>
Signed-off-by: fishbell <bell.song@intel.com>
@songbell songbell requested a review from rkazants November 10, 2021 05:59
@rkazants
Copy link
Collaborator

@tsavina, could you please review it from the grammar perspective?

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>
@azhogov azhogov merged commit f06aa99 into openvinotoolkit:master Nov 23, 2021
openvino-dev-samples pushed a commit to openvino-dev-samples/openvino that referenced this pull request Nov 23, 2021
* revise RNN spec

Signed-off-by: fishbell <bell.song@intel.com>

* formatting the formula

Signed-off-by: fishbell <bell.song@intel.com>

* Update docs/ops/sequence/RNNSequence_5.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>
openvino-dev-samples pushed a commit to openvino-dev-samples/openvino that referenced this pull request Nov 24, 2021
* revise RNN spec

Signed-off-by: fishbell <bell.song@intel.com>

* formatting the formula

Signed-off-by: fishbell <bell.song@intel.com>

* Update docs/ops/sequence/RNNSequence_5.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants