Skip to content

Conversation

@nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented May 21, 2025

Rewrite native Poseidon2 chip for execution/tacegen.

@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Walltime Performance Report

Merging #1672 will not alter performance

Comparing feat/poseidon2-chip (d400885) with feat/new-execution (cb2a533)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Instrumentation Performance Report

Merging #1672 will not alter performance

Comparing feat/poseidon2-chip (d400885) with feat/new-execution (cb2a533)

Summary

✅ 10 untouched benchmarks

Base automatically changed from feat/new-exec-native-ext to feat/new-execution May 22, 2025 04:58
@nyunyunyunyu nyunyunyunyu force-pushed the feat/poseidon2-chip branch from 1491662 to 44932bc Compare May 23, 2025 04:44
@github-actions

This comment has been minimized.

@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review May 23, 2025 22:33
@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-92 [-8.1%]) 1,040 334,014 (-1224170 [-6.9%]) 16,451,592 - - -
fibonacci (-277 [-11.2%]) 2,194 1,500,277 50,578,543 - - -
regex (-618 [-8.4%]) 6,759 4,165,432 (-3513918 [-2.1%]) 162,997,234 - - -
ecrecover (+92 [+6.6%]) 1,480 289,547 (-1180984 [-8.2%]) 13,289,202 - - -
pairing (-169 [-3.7%]) 4,390 1,820,436 (-16223094 [-16.9%]) 79,609,313 - - -

Commit: d400885

Benchmark Workflow

Copy link
Collaborator

@shuklaayush shuklaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. all tests pass except test_vm_compress_poseidon2_as4 which we can investigate later. we should probably clean this up and break into small pieces at some point to make it easy to understand

@nyunyunyunyu nyunyunyunyu merged commit cc62f86 into feat/new-execution May 23, 2025
22 of 28 checks passed
@nyunyunyunyu nyunyunyunyu deleted the feat/poseidon2-chip branch May 23, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants