Skip to content

Conversation

@Golovanov399
Copy link
Contributor

We sometimes call set_initial_memory even with Volatile interface chip. Don't know if this alone is a good design, but inside this function we reset the tracing memory to use 8 as initial_block_size and then checked that in the volatile case the memory is empty, but the initial block size was already overwritten. This change fixes it.

@codspeed-hq
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Walltime Performance Report

Merging #1690 will not alter performance

Comparing fix/new-execution-set-initial-memory (721916d) with feat/new-execution (cc62f86)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-107 [-9.5%]) 1,025 334,086 (-1223306 [-6.9%]) 16,452,456 - - -
fibonacci (-273 [-11.0%]) 2,198 1,500,277 50,578,543 - - -
regex (-624 [-8.5%]) 6,753 4,165,432 (-3513918 [-2.1%]) 162,997,234 - - -
ecrecover (+62 [+4.5%]) 1,450 289,547 (-1180984 [-8.2%]) 13,289,202 - - -
pairing (-131 [-2.9%]) 4,428 1,820,436 (-16223094 [-16.9%]) 79,609,313 - - -

Commit: 721916d

Benchmark Workflow

@codspeed-hq
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Instrumentation Performance Report

Merging #1690 will not alter performance

Comparing fix/new-execution-set-initial-memory (721916d) with feat/new-execution (cc62f86)

Summary

✅ 10 untouched benchmarks

@Golovanov399 Golovanov399 merged commit e9bc13d into feat/new-execution May 24, 2025
24 of 28 checks passed
@Golovanov399 Golovanov399 deleted the fix/new-execution-set-initial-memory branch May 24, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants