-
Notifications
You must be signed in to change notification settings - Fork 83
fix(new-execution): use unpadded height for segmentation #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(new-execution): use unpadded height for segmentation #1698
Conversation
shuklaayush
commented
May 29, 2025
- use unpadded height when calculating max height and total cells during segmentation
- use default segmentation thresholds from reth benchmark
CodSpeed Walltime Performance ReportMerging #1698 will not alter performanceComparing
|
This comment has been minimized.
This comment has been minimized.
CodSpeed Instrumentation Performance ReportMerging #1698 will not alter performanceComparing Summary
|
| for (i, &height) in trace_heights.iter().enumerate() { | ||
| let padded_height = height.next_power_of_two(); | ||
| if padded_height > MAX_TRACE_HEIGHT { | ||
| if height > MAX_TRACE_HEIGHT { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAX_TRACE_HEIGHT isn't configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not atm. i'll fix this in a follow up
64e8c49 to
7b18c95
Compare
Commit: 7b18c95 |