Skip to content

Conversation

@shuklaayush
Copy link
Collaborator

  • use unpadded height when calculating max height and total cells during segmentation
  • use default segmentation thresholds from reth benchmark

@shuklaayush shuklaayush requested a review from jonathanpwang May 29, 2025 22:44
@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Walltime Performance Report

Merging #1698 will not alter performance

Comparing feat/new-exec-fix-e2-height-padding (7b18c95) with feat/new-execution (c9c7240)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@github-actions

This comment has been minimized.

@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Instrumentation Performance Report

Merging #1698 will not alter performance

Comparing feat/new-exec-fix-e2-height-padding (7b18c95) with feat/new-execution (c9c7240)

Summary

✅ 10 untouched benchmarks

for (i, &height) in trace_heights.iter().enumerate() {
let padded_height = height.next_power_of_two();
if padded_height > MAX_TRACE_HEIGHT {
if height > MAX_TRACE_HEIGHT {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAX_TRACE_HEIGHT isn't configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not atm. i'll fix this in a follow up

@shuklaayush shuklaayush force-pushed the feat/new-exec-fix-e2-height-padding branch from 64e8c49 to 7b18c95 Compare May 30, 2025 11:40
@shuklaayush shuklaayush merged commit 3f3147b into feat/new-execution May 30, 2025
17 of 21 checks passed
@shuklaayush shuklaayush deleted the feat/new-exec-fix-e2-height-padding branch May 30, 2025 11:41
@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-153 [-12.9%]) 1,034 334,142 (-1223570 [-6.9%]) 16,453,128 - - -
fibonacci (-324 [-12.9%]) 2,186 1,500,277 50,578,543 - - -
regex (-603 [-8.2%]) 6,762 4,165,432 (-3513918 [-2.1%]) 162,997,234 - - -
ecrecover (+53 [+3.8%]) 1,442 289,547 (-1180984 [-8.2%]) 13,289,202 - - -
pairing (-70 [-1.6%]) 4,427 1,820,436 (-16223094 [-16.9%]) 79,609,313 - - -

Commit: 7b18c95

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants