Skip to content

test: run sha2 test vectors together#2397

Merged
gdmlcjs merged 1 commit intodevelop-v1.6.0from
test/sha2-guest
Feb 6, 2026
Merged

test: run sha2 test vectors together#2397
gdmlcjs merged 1 commit intodevelop-v1.6.0from
test/sha2-guest

Conversation

@gdmlcjs
Copy link

@gdmlcjs gdmlcjs commented Feb 6, 2026

Made the test guest program process all of the test vectors in a single run.
Time to run tests has decreased so all the SHA2 tests are now run on a single machine, like it was before the test suite was added.

@gdmlcjs gdmlcjs self-assigned this Feb 6, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2026

Merging this PR will degrade performance by 82.78%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 9 regressed benchmarks
✅ 15 untouched benchmarks
⏩ 36 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime benchmark_execute_metered[fibonacci_recursive] 16.9 ms 53.3 ms -68.22%
WallTime benchmark_execute_metered[bubblesort] 11.3 ms 46.9 ms -76.01%
WallTime benchmark_execute_metered[revm_snailtracer] 7.3 ms 42.5 ms -82.78%
WallTime benchmark_execute_metered[quicksort] 9 ms 44.7 ms -79.79%
WallTime benchmark_execute_metered[keccak256] 11.1 ms 49.3 ms -77.47%
WallTime benchmark_execute_metered[keccak256_iter] 71.7 ms 190.2 ms -62.32%
WallTime benchmark_execute_metered[fibonacci_iterative] 14.3 ms 49.4 ms -71.04%
WallTime benchmark_execute_metered[revm_transfer] 24.9 ms 59.6 ms -58.24%
WallTime benchmark_execute_metered[sha256] 9.3 ms 44.1 ms -78.86%

Comparing test/sha2-guest (f6e166c) with develop-v1.6.0 (6dc3800)2

Open in CodSpeed

Footnotes

  1. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop-v1.6.0 (5a93213) during the generation of this report, so 95fdcd5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@gdmlcjs gdmlcjs marked this pull request as ready for review February 6, 2026 22:34
@gdmlcjs gdmlcjs requested a review from jonathanpwang February 6, 2026 22:34
@gdmlcjs gdmlcjs merged commit 53464de into develop-v1.6.0 Feb 6, 2026
32 of 35 checks passed
@gdmlcjs gdmlcjs deleted the test/sha2-guest branch February 6, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants