feat: rv64 jal lui jalr auipc#2475
Merged
876pol merged 4 commits intorv64-mul-mulh-divremfrom Mar 4, 2026
Merged
Conversation
1fc5cbf to
35149d8
Compare
67389e3 to
984ef5e
Compare
jonathanpwang
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-6322, INT-6338, INT-6339.
Summary:
jal_lui,jalr, andauipcsubmodules ofriscvhave been ported from RV32 to RV64Rv32*toRv64*(e.g.,Rv32JalLuiCoreAir→Rv64JalLuiCoreAir,Rv32JalrExecutor→Rv64JalrExecutor)u32/4 bytes tou64/8 bytes throughout (registers, read/write operations)Rv64JalrAdapterandRv64RdWriteAdapter/Rv64CondRdWriteAdapterupdated for RV64 register widthRV64_WORD_NUM_LIMBSconstant (RV64_REGISTER_NUM_LIMBS / 2 = 4) introduced for 32-bit sub-word operations within 64-bit registersrdpc + 4(always fits in 32 bits) intordrs1(low 32 bits used) andrd(pc + 4)pc + (imm << 12)intordjal_luiwhere:is_sign_extendcolumn is addedBitwiseOperationLookupBus::send_xor(rd[3], 11000000₂, rd[3] + 11000000₂).eval(is_jal)has been changed toBitwiseOperationLookupBus::send_range(rd[3] * (4 * is_jal + is_lui), 2 * rd[3] - is_sign_extend * 256).eval(is_jal + is_lui)(this is valid sincerd[3]has already been constrained to[0, 256))jal_luiandjalr(transpiler already prevents writing to x0 inauipc)rd_upper_bytes_trace_tamper_negative_test,rs1_upper_bytes_trace_tamper_negative_test) forauipc,jal_lui, andjalrto verify that the zero/sign-extended upper 4 bytes are properly constrained by the memory busjal_lui,jalr, andauipcinlib.rs; all three fully wired up inextension/mod.rs