chore: rename NATIVE_AS to DEFERRAL_AS and remove pvs chip#2480
Merged
stephenh-axiom-xyz merged 2 commits intodevelop-v2.0.0-betafrom Mar 3, 2026
Merged
chore: rename NATIVE_AS to DEFERRAL_AS and remove pvs chip#2480stephenh-axiom-xyz merged 2 commits intodevelop-v2.0.0-betafrom
stephenh-axiom-xyz merged 2 commits intodevelop-v2.0.0-betafrom
Conversation
shuklaayush
approved these changes
Mar 3, 2026
Collaborator
shuklaayush
left a comment
shuklaayush
left a comment
There was a problem hiding this comment.
lgtm. the cleanups can be addressed in follow-ups
| &mut self, | ||
| system_records: SystemRecords<Val<SC>>, | ||
| mut record_arenas: Vec<RA>, | ||
| _record_arenas: Vec<RA>, |
Collaborator
There was a problem hiding this comment.
wonder if we can remove this now from the trait
| use crate::system::{cuda::boundary::BoundaryFields, PUBLIC_VALUES_AIR_ID}; | ||
|
|
||
| let boundary_idx = PUBLIC_VALUES_AIR_ID + usize::from(self.public_values.is_some()); | ||
| let boundary_idx = PUBLIC_VALUES_AIR_ID; |
Collaborator
There was a problem hiding this comment.
should probably rename this constant to something more appropriate now
Contributor
There was a problem hiding this comment.
i guess BOUNDARY_AIR_IDX is apt?
Contributor
There was a problem hiding this comment.
@claude make a PR to branch develop-v2.0.0-beta to rename PUBLIC_VALUES_AIR_ID to BOUNDARY_AIR_IDX. Make sure all CI tests pass.
There was a problem hiding this comment.
Claude finished @jonathanpwang's task in 13s —— View job • claude/pr-2480-20260304-0340 • [Create PR ➔](https://github.com/openvm-org/openvm/compare/main...claude/pr-2480-20260304-0340?quick_pull=1&title=PR%20%232480%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20pr%20%232480%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)
Renaming PUBLIC_VALUES_AIR_ID to BOUNDARY_AIR_IDX
- Find all occurrences of
PUBLIC_VALUES_AIR_ID(8 files) - Rename to
BOUNDARY_AIR_IDX - Build check (
openvm-circuitcompiles successfully) - Fix import ordering (caught by CI fmt check)
- Commit and push changes
- Create PR targeting
develop-v2.0.0-beta: chore: renamePUBLIC_VALUES_AIR_IDtoMEMORY_AIRS_START_IDX#2482 - Verify CI passes
CI Status
| Check | Status |
|---|---|
| Lint | ✅ pass |
| Lint CUDA | ✅ pass |
| tests | ✅ pass |
| tests-cuda | ✅ pass |
All CI checks pass.
| View PR branch
claude bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
The PublicValuesChip was removed in #2480, making the old name misleading. Rename the constant to BOUNDARY_AIR_IDX which better reflects its current role as the boundary AIR index. Co-authored-by: Jonathan Wang <jonathanpwang@users.noreply.github.com>
jonathanpwang
added a commit
that referenced
this pull request
Mar 4, 2026
## Summary - Renames the constant `PUBLIC_VALUES_AIR_ID` to `MEMORY_AIRS_START_IDX` across 8 files - Removes old unused `BOUNDARY_AIR_ID` - Updates the doc comment to reflect the constant's current purpose as the boundary AIR index - The `PublicValuesChip` was removed in #2480, making the old name misleading Follows up on review comment in #2480. Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Jonathan Wang <jonathanpwang@users.noreply.github.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Ayush Shukla <shuklaayush@users.noreply.github.com> Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
jpw-axiom
pushed a commit
that referenced
this pull request
Mar 5, 2026
jpw-axiom
pushed a commit
that referenced
this pull request
Mar 5, 2026
## Summary - Renames the constant `PUBLIC_VALUES_AIR_ID` to `MEMORY_AIRS_START_IDX` across 8 files - Removes old unused `BOUNDARY_AIR_ID` - Updates the doc comment to reflect the constant's current purpose as the boundary AIR index - The `PublicValuesChip` was removed in #2480, making the old name misleading Follows up on review comment in #2480. Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Jonathan Wang <jonathanpwang@users.noreply.github.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Ayush Shukla <shuklaayush@users.noreply.github.com> Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards INT-6435.
NATIVE_AStoDEFERRAL_ASPublicValuesChipand native adapter (utils moved torv32im)