fix(v2.1): change block size in ecc chips to 4#2647
Merged
shuklaayush merged 3 commits intodevelop-v2.1.0from Apr 2, 2026
Merged
fix(v2.1): change block size in ecc chips to 4#2647shuklaayush merged 3 commits intodevelop-v2.1.0from
shuklaayush merged 3 commits intodevelop-v2.1.0from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
04fd82b to
e561053
Compare
d788267 to
b4e7834
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
12c054c to
c03ed4d
Compare
|
Claude finished @shuklaayush's task in 1m 15s —— View job
OverviewThe PR correctly adapts the projective ECC extension to v2's VerificationConstants (
All call sites updated consistently:
No remaining hardcoded CUDA router (
Ancillary changes:
VerdictLGTM. The fix is complete, consistent, and well-scoped. No issues found. |
Note: cells_used metrics omitted because CUDA tracegen does not expose unpadded trace heights. Commit: c03ed4d |
|
LGTM aside from the two naming cleanups! |
shuklaayush
added a commit
that referenced
this pull request
Apr 2, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 2, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 8, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 8, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 9, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 9, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 10, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 10, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
shuklaayush
added a commit
that referenced
this pull request
Apr 10, 2026
Adapt projective EC extension to v2's `DEFAULT_BLOCK_SIZE=4` memory constraint. The projective coordinates code used `BLOCK_SIZE=32` (secp256k1) and `BLOCK_SIZE=16` (BLS12-381) for memory accesses, but v2's `TracingMemory` enforces 4-cell accesses. This updates: - `ECC_BLOCKS` constants from `2 * NUM_LIMBS / 4` (affine, 2 coords) to `3 * NUM_LIMBS / 4` (projective, 3 coords) - All hardcoded `<3, 32>` / `<9, 16>` const generics to `<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>` in extension, hybrid, and test code - Test helpers to write memory in 4-byte chunks resolves int-6644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapt projective EC extension to v2's
DEFAULT_BLOCK_SIZE=4memory constraint.The projective coordinates code used
BLOCK_SIZE=32(secp256k1) andBLOCK_SIZE=16(BLS12-381) for memory accesses, but v2'sTracingMemoryenforces 4-cell accesses. This updates:ECC_BLOCKSconstants from2 * NUM_LIMBS / 4(affine, 2 coords) to3 * NUM_LIMBS / 4(projective, 3 coords)<3, 32>/<9, 16>const generics to<ECC_BLOCKS_N, DEFAULT_BLOCK_SIZE>in extension, hybrid, and test coderesolves int-6644