Closed
Conversation
… AssertSortedChip
Contributor
|
@MonkeyKing-1 can you merge |
Contributor
|
Superseded by #198 |
jonathanpwang
pushed a commit
that referenced
this pull request
Mar 9, 2025
**Finding Link:** Internal finding. ## Description of Fix Since each block adds 17 rows, the unpadded trace height is always a multiple of 17 and thus never a power of 2. So there will always be at least one padding row following the last block. It was discovered that this assumption is already being used in one place: when calling `eval_prev_hash`. The SHA-256 VM extension spec update PR documents this assumption in code comments. See axiom-crypto/openvm-private#69 This PR removes a constraint that becomes redundant given the assumption that there is always at least one padding row following the last block. More specifically, it cannot be the case that it is the last row of the trace and it is also a digest row, so the removed constraint is never enforced.
jonathanpwang
pushed a commit
that referenced
this pull request
Mar 9, 2025
**Finding Link:** Internal finding. ## Description of Fix Since each block adds 17 rows, the unpadded trace height is always a multiple of 17 and thus never a power of 2. So there will always be at least one padding row following the last block. It was discovered that this assumption is already being used in one place: when calling `eval_prev_hash`. The SHA-256 VM extension spec update PR documents this assumption in code comments. See axiom-crypto/openvm-private#69 This PR removes a constraint that becomes redundant given the assumption that there is always at least one padding row following the last block. More specifically, it cannot be the case that it is the last row of the trace and it is also a digest row, so the removed constraint is never enforced.
jpw-axiom
pushed a commit
that referenced
this pull request
Feb 16, 2026
jpw-axiom
pushed a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the list of commands to run:
cargo run --release --bin afs-1b -- mock write -f bin/afs-1b/tests/data/test_input_file_32_1024.afi -d bin/afs-1b/tests/data/db -o my_table
(This creates a table named my_table, initialized with data from test_input_file_32_1024)
cargo run --release --bin afs-1b -- keygen -o bin/afs-1b/tests/data/keys
cargo run --release --bin afs-1b -- prove -k bin/afs-1b/tests/data/keys -f bin/afs-1b/tests/data/56k_write_32_1024.afi -d bin/afs-1b/tests/data/db -c bin/afs-1b/tests/data/db
cargo run --release --bin afs-1b -- verify -t my_table -d bin/afs-1b/tests/data/db -k bin/afs-1b/tests/data/keys