Skip to content

Conversation

@kholia
Copy link
Member

@kholia kholia commented Sep 6, 2017

This tries to cleanup #2728 and extend it a bit.

@e-ago Please review this pull request and make sure that I have included all your code changes. Thanks!

@e-ago I have two requests for you. First, can you please add code comments in the OpenCL kernel? Specifically, I would like to know which parts of the kernel are doing SHA-256 operations, and which parts are doing the AES-CCM operations. Second, can support for password lengths < 8 be also added?

@magnumripper
Copy link
Member

magnumripper commented Sep 6, 2017

Second, can support for password lengths < 8 be also added?

Does BitLocker allow that in real life? If it does, this is absolutely mandatory.

@kholia
Copy link
Member Author

kholia commented Sep 6, 2017

@magnumripper I am wondering about the same. I will try generating such a test vector soon on Windows 10.

@kholia
Copy link
Member Author

kholia commented Sep 6, 2017

The minimum password length seems to be 8 for BitLocker,

bitlocker-minimum-length-is-8

@kholia kholia merged commit d1e303e into openwall:bleeding-jumbo Sep 6, 2017
@e-ago
Copy link
Contributor

e-ago commented Sep 6, 2017

Thank you. Yes, 8 is the minimum length.

@kholia I will make a new PR (from an updated fork) to add the comments you requested.

@magnumripper
Copy link
Member

https://technet.microsoft.com/en-us/library/jj679890(v=ws.11).aspx
Passwords must be at least 8 characters. To configure a greater minimum length for the password, enter the desired number of characters in the Minimum password length box.

If I get that technote right, it's configurable - but even then you can't set it shorter than 8.

@kholia
Copy link
Member Author

kholia commented Sep 7, 2017

@magnumripper I agree with your interpretation of the technote.

@kholia kholia deleted the BitLocker branch March 7, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants