Skip to content

Make Apple Keychain format more robust#5978

Open
kholia wants to merge 1 commit intobleeding-jumbofrom
better-apple-keychain-support
Open

Make Apple Keychain format more robust#5978
kholia wants to merge 1 commit intobleeding-jumbofrom
better-apple-keychain-support

Conversation

@kholia
Copy link
Copy Markdown
Member

@kholia kholia commented Apr 21, 2026

Closes #3408

This only took 14 years (after the initial format release in 2012)...

CC @magnumripper @solardiz

@kholia kholia self-assigned this Apr 21, 2026
@solardiz
Copy link
Copy Markdown
Member

Thank you very much @kholia. I don't have time to look at this for real now - hopefully soon. Meanwhile, you could want to see why two CI jobs are failing here.

@kholia kholia force-pushed the better-apple-keychain-support branch from 4476c2c to f0eb593 Compare April 25, 2026 02:47
@kholia
Copy link
Copy Markdown
Member Author

kholia commented Apr 25, 2026

The CI infrastructure is running into problems:

Configure finished.  Now "make -s clean && make -sj2" to compile.
The authenticity of host 'github.com (140.82.112.3)' can't be established.
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.
This key is not known by any other names.
Are you sure you want to continue connecting (yes/no/[fingerprint])? make[1]: *** Deleting file 'misc.o'
make[1]: *** Deleting file 'memory.o'
make[1]: *** Deleting file 'mask.o'
make[1]: *** Deleting file 'loader.o'
make: *** [Makefile:202: default] Hangup

Too long with no output (exceeded 10m0s): context deadline exceeded

@magnumripper
Copy link
Copy Markdown
Member

Why the name change for keypass2john.py? In general that is messy and can lead to problems in some setups. Did syntax/options change?

@kholia
Copy link
Copy Markdown
Member Author

kholia commented Apr 27, 2026

Good point. I believe we can keep the same name as the script is mostly backwards compatible.

@kholia kholia force-pushed the better-apple-keychain-support branch from f0eb593 to 59a7569 Compare April 28, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Apple Keychain format more robust

3 participants