Make Apple Keychain format more robust#5978
Open
kholia wants to merge 1 commit intobleeding-jumbofrom
Open
Conversation
Member
|
Thank you very much @kholia. I don't have time to look at this for real now - hopefully soon. Meanwhile, you could want to see why two CI jobs are failing here. |
4476c2c to
f0eb593
Compare
Member
Author
|
The CI infrastructure is running into problems: |
Member
|
Why the name change for keypass2john.py? In general that is messy and can lead to problems in some setups. Did syntax/options change? |
Member
Author
|
Good point. I believe we can keep the same name as the script is mostly backwards compatible. |
f0eb593 to
59a7569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3408
This only took 14 years (after the initial format release in 2012)...
CC @magnumripper @solardiz