Makefile: Pass CFLAGS to the compiler when invoking the linker.#23
Merged
solardiz merged 1 commit intoopenwall:mainfrom Dec 16, 2024
Merged
Conversation
Some CFLAGS imply effects on the linker too (e.g., -fsanitize=), so they must get passed within the linker rule as well. Signed-off-by: Björn Esser <besser82@fedoraproject.org>
Member
|
Looks good to me, although I'm not sure what the current best practice is. |
ldv-alt
approved these changes
Dec 16, 2024
Collaborator
ldv-alt
left a comment
ldv-alt
left a comment
There was a problem hiding this comment.
Yes, this is the accepted way of doing the linking nowadays.
For example, GNU automake is generating that kind of linking rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CFLAGS imply effects on the linker too (e.g., -fsanitize=), so they must get passed within the linker rule as well.