Add bbox support to API, fix station search with query#251
Merged
Conversation
Bump @neaps/tide-database from 0.6/* to 0.7 in neaps and cli packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add bbox query parameter to GET /stations endpoint - Use bbox() from @neaps/tide-database 0.7 (takes [minLon, minLat, maxLon, maxLat] tuple) - Add allowReserved to search query parameter for reserved characters like commas - Add tests for bbox filtering, empty results, and invalid format Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the @neaps/tide-database from #220 and the @neaps/api changes from #249.
Add
bboxquery parameter toGET /stationsfor filtering stations by bounding box. Pass a comma-separated stringminLon,minLat,maxLon,maxLatto return only stations within that geographic area.Also allows reserved characters (e.g. commas) in the
queryparameter, enabling searches like"San Francisco, CA".Bump
@neaps/tide-databasedependency to0.7.