Skip to content

Change signature of bcd.skipIf() #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
queengooborg merged 1 commit into from
Jan 28, 2024
Merged

Change signature of bcd.skipIf() #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions custom/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2256,7 +2256,7 @@ api:
}
return bcd.testOptionParam(createContext, null, 'willReadFrequently', true);
webgpu_context: |-
bcd.skipIf('safari', '16.5', 'Creating a WebGPU context on Safari 16.5 crashes the browser');
bcd.skipIf('Creating a WebGPU context on Safari 16.5 crashes the browser', 'safari', '16.5');

if (!(instance && instance.getContext)) {
return {result: false, message: 'instance.getContext is not defined'};
Expand Down Expand Up @@ -3919,7 +3919,7 @@ api:
var instance = reusableInstances.audioContext.createScriptProcessor();
SecurityPolicyViolationEvent:
__base: |-
bcd.skipIf('edge', '15', 'Constructing this event causes the page to reload');
bcd.skipIf('Constructing this event causes the page to reload', 'edge', '15');

if (!('SecurityPolicyViolationEvent' in self)) {
return {result: false, message: 'SecurityPolicyViolationEvent is not defined'};
Expand Down
22 changes: 10 additions & 12 deletions static/resources/harness.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,23 +208,21 @@
/**
* Skips the test by throwing an error if the browser (and possibly version) matches
* Avoid using this if possible
* @param {string?} reason - The reason for skipping
* @param {string} browserName - The name of the browser to skip
* @param {string?} browserVersion - The browser version to skip, if needed
* @param {string?} reason - The reason for skipping
*/
function skipIf(browserName, browserVersion, reason) {
if (!browserName) {
return;
}

if (browserName !== browser.name) {
return;
}

if (browserVersion) {
if (browserVersion !== browser.version) {
function skipIf(reason, browserName, browserVersion) {
if (browserName) {
if (browserName !== browser.name) {
return;
}

if (browserVersion) {
if (browserVersion !== browser.version) {
return;
}
}
}

throw new Error(
Expand Down