Remove the feedback header click close behavior and instead add a close button. #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
approved these changes
Apr 10, 2024
…se button. This is a possible fix to issue #2362 that might be better than the attempt in openwebwork#1036. This adds a close button to feedback popover headers. The previous behavior of clicking on the header to close it has been removed in favor of this close button.
drgrice1
force-pushed
the
feedback-popover-close-btn
branch
2 times, most recently
from
276cd07 to
aedc80c
Compare
Contributor
|
This is a good improvement, and I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix to issue #2362 that might be better than the attempt in #1036.
This adds a close button to feedback popover headers. The previous behavior of clicking on the header to close it has been removed in favor of this close button.