Possible fix for the eval issue.#1344
Merged
dlglin merged 1 commit intoopenwebwork:developfrom Nov 25, 2025
Merged
Conversation
Contributor
Member
Author
This is a possible fix for openwebwork#1340. This is now @dpvc's suggested code from his comment in openwebwork#1340.
drgrice1
force-pushed
the
bugfix/context-fraction-eval-issue
branch
from
59f7d6a to
3c05a41
Compare
somiaj
approved these changes
Nov 6, 2025
Contributor
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Confirmed this fixed both MWE in the issue.
dpvc
approved these changes
Nov 7, 2025
Contributor
|
Worth adding this to the list of hotfixes to contextFraction? |
dlglin
added a commit
that referenced
this pull request
Nov 25, 2025
…l-issue-hotfix Possible fix for the eval issue. (hotfix of #1344)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #1340. Instead of calling the
evalmethod in thecontext::Fraction::Value::Realmethod for a Value Fraction object, just use the perl quotient of the numerator and denominator. That is then mutated into a real in the return value.Edit: This is now @dpvc's suggested code from his comment in #1340.