Pg critic fixes for older perl#1411
Merged
pstaabp merged 1 commit intoMay 19, 2026
Merged
Conversation
Using `//=` in signatures is a feature that is not available until version 5.28 of perl. I am not entirely certain of why the added `to_string` is needed or why it works with newer versions of perl, but it causes an issue with older perl versions as well. This fixes issue openwebwork/webwork2#2978.
Alex-Jordan
approved these changes
May 19, 2026
somiaj
reviewed
May 19, 2026
Contributor
|
@somiaj If you are good with this, would you go ahead and merge it? I am not easily able to test a lot until this is in, or else I have to separately track having this patch in place. |
Contributor
|
I've only looked at the code and haven't actually had time to test it. I assume it works, but want to test it before merging. Note you could always just |
Member
|
Let's merge this. It's only the perl critic code and shouldn't affect the general use. |
pstaabp
approved these changes
May 19, 2026
Member
|
@Alex-Jordan let us know if this fixes it. |
Member
Author
|
This does affect general use as issue openwebwork/webwork2#2978 shows. |
Contributor
|
Yes, the changes here resolved the issues I was hitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
//=in signatures is a feature that is not available until version 5.28 of perl. In this case that isn't needed since thewalkPGMLTreeis never called without that argument.I am not entirely certain of why the added
to_stringis needed or why it works with newer versions of perl, but it causes an issue with older perl versions as well.This fixes issue openwebwork/webwork2#2978.