Skip to content

empty node following booktabs rules#1420

Merged
somiaj merged 1 commit into
openwebwork:PG-2.21from
Alex-Jordan:niceTables-midrule
May 26, 2026
Merged

empty node following booktabs rules#1420
somiaj merged 1 commit into
openwebwork:PG-2.21from
Alex-Jordan:niceTables-midrule

Conversation

@Alex-Jordan
Copy link
Copy Markdown
Contributor

This addresses openwebwork/webwork2#2697.

Copy link
Copy Markdown
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the issue.

@somiaj
Copy link
Copy Markdown
Contributor

somiaj commented May 26, 2026

When testing this, it seems to add an extra cell to the table. It does fix the hang, but the generated table in hardcopy has an extra cell.

image

To test this I removed the PopUp causing issues, and here is the difference between PG-2.21 and this branch.

PG-2.21 branch:

image

This branch:

image

@Alex-Jordan Alex-Jordan force-pushed the niceTables-midrule branch from 22bda51 to bb4678c Compare May 26, 2026 15:06
@Alex-Jordan
Copy link
Copy Markdown
Contributor Author

Nice catch @somiaj. Try it now. It only adds the empty node if it is not the last row.

@somiaj somiaj merged commit c049913 into openwebwork:PG-2.21 May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants