subMatrix method for Matrix Math Objects#1424
Open
Alex-Jordan wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I've discovered a few issues with this. Pausing the PR until I make a few corrections. |
Contributor
Author
|
Now three commits total. The first is basically @pstaabp's code from #1076 for |
pstaabp
approved these changes
May 29, 2026
Member
pstaabp
left a comment
pstaabp
left a comment
There was a problem hiding this comment.
Looks good. Thanks for looking back to that PR to include these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is another one from #1076. This one is ripped directly from #1076, and I committed it as @pstaabp's commit. Only change I made was to move the auxiliary subroutine
extractElementsinside this method. I don't see a need to make that accessible as a method, but you can let me know if it should be.