Develop multi ling 03 10 2019 no mb4 pg#402
Closed
mgage wants to merge 19 commits into
Closed
Conversation
…esn't interfere with utf8
create records in PG->{flags} with settings which will influence the
HTML lang and dir attributes set for the HTML element containing the
problem. This allows proper detection of the language of the problem in
the browser, when it is not the primary course language, and to override
the direction for cases when a LTR problem is being viewed/assigned in a
course in a RTL course, or visa-versa. The flag values set in the problem
are processed in the subroutine output_problem_lang_and_dir() in
webwork2/lib/WeBWorK/ContentGenerator/Problem.pm
if there is no override set in the course configuration.
set flags for the problem language and textdirection which can be accessed inside the webwork2 code to allow using this data to set the HTML lang and dir tags as needed on DIV elements which envelop the problem text.
Develop utf8 ver2
…ction_to_PG_flags Add lang and direction to pg flags
…e Encoding.pm file
Develop unit tests2
…eviewers of multilingual
Member
|
I have not yet had a chance to test the code in this new PR for multi lingual support. However:
|
Member
Author
|
Perhaps the lack of the colon is why encode(UTF-8) didn't work, but I don't think so. I think it was a conflict with Safe. I was wondering if the PGloadmacros.pl was run before Safe was locked down -- but it appeared this was not the case. What is there now should be approximately equivalent to <:utf8 but allows for some additional intervention if that turns out to be helpful. utf8::upgrade() for example seems to try to upgrade latin1 text to utf8. I'm not sure how reliable it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tweak encode(UTF-8) and :utf8 layers for input/output. This version should work with legacy courses and versions of mysql older than 5.3 which cannot handle utf8mb4. This replaces PR #390