Correct value for electron volt in Units.pm #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct exponential for factor of eV fixes openwebwork#677 Adds definitions for kev, MeV and GeV Remove t/README because it has been superseded by t/README.md
pstaabp
approved these changes
Jun 5, 2022
Member
pstaabp
left a comment
pstaabp
left a comment
There was a problem hiding this comment.
The splitting up of the code into different PRs is the way to go with this. This looks good.
This was referenced Jun 6, 2022
Alex-Jordan
approved these changes
Jun 29, 2022
Contributor
Alex-Jordan
left a comment
Alex-Jordan
left a comment
There was a problem hiding this comment.
Approving. In a future commit, I might review all of the natural constants in Units.pm and replace them with closer to full precision. So for example I might change 1.6022 to 1.602176634 based on NIST. But I don't think that should hold this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct exponential for factor of eV
fixes #677
Adds definitions for kev, MeV and GeV
Remove t/README because it has been superseded by t/README.md