Fix indexing in case R1 <-> R2 #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When swapping row 1 and row 2, there was $a12 instead of $a21. That would cause about 1/3 of the generated problems to have one of the 27 answers wrong.
drdrew42
approved these changes
Feb 25, 2022
Member
drdrew42
left a comment
drdrew42
left a comment
There was a problem hiding this comment.
Confirmed, though it took a while to find a seed that swapped R1 and R2...
Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swapping row 1 and row 2, there was $a12 instead of $a21. That
would cause about 1/3 of the generated problems to have one of the 27
answers wrong.