Add the eslint space-infix-ops rule and general clean up #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Wait a bit with this. |
Member
Author
|
Okay, this is ready. |
Update the remaining import statements to use the provided quasar webpack alias. Fix my mistake with the jest configuration. I seem to have mixed the two methods I suggested, instead of only using one. I installed require-json5, but didn't use it. I did intend to use that, rather than adding all of the aliases in jest.config.js, and so that is done here.
exceptions. Those aren't needed.
Member
Author
|
There are a few others also. All of the aliases provided by quasar are listed at https://quasar.dev/quasar-cli/handling-webpack#webpack-aliases. Yeah, I think this should be merged, and then the conflicts in #63 resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remaining incorrect Ref usages.
Update the remaining import statements to use the provided quasar webpack alias.
Fix my mistake with the jest configuration. I seem to have mixed the two methods I suggested, instead of only using one. I installed require-json5, but didn't use it. I did intend to use that, rather than adding all of the aliases in jest.config.js, and so that is done here.