fix(openworkflow): only transform PG column names, not JSON value object keys#368
Merged
jamescmartinez merged 1 commit intomainfrom Mar 5, 2026
Merged
fix(openworkflow): only transform PG column names, not JSON value object keys#368jamescmartinez merged 1 commit intomainfrom
jamescmartinez merged 1 commit intomainfrom
Conversation
commit: |
There was a problem hiding this comment.
Pull request overview
Fixes a Postgres backend bug where enabling postgres.toCamel globally was also mutating keys inside JSONB payloads (e.g., workflow run input), ensuring user-provided JSON keys are preserved exactly as provided.
Changes:
- Scope Postgres.js
transformto apply only to result column names (not JSON value object keys). - Add a regression test that verifies uppercase snake_case JSON keys survive create + readback (API and raw DB query).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/openworkflow/postgres/postgres.ts | Updates Postgres client creation to transform only column names via transform.column.from. |
| packages/openworkflow/postgres/backend.test.ts | Adds regression coverage for JSON key preservation in workflow run input, both via backend API and direct SQL read. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367
See test or original GH issue for details.